It always seemed to me that training was a rite of passage. Like, most kids go off for a little while to be a pokemon trainer, have their adventures and earn a few badges, and then they come home and settle down to figure out what they want to do with their life. It's kind of like going to college in our world. You gain valuable experience, make new friends, learn skills, and when that's all said and done, you come back home and use the things you learned to figure out where you want to go in your life. Some people become gym leaders, others go on to become professors, and some just become ordinary people, working a nine to five job, just with a pokemon or two back home. And then there are others who keep on wandering and never put down roots, and that's okay too.
So yeah, I would be/would have been a trainer, but I don't think people are trainers their entire lives. It's something you do for a few years, and then it's time to grow up. I think a lot of the people who are saying they would eventually settle down in this thread are the people who are in college or out of college and are going through that now, and the ones who are simply saying "Heck yeah I'd be a trainer forever!" are the kids who still have a lot of time left ahead of them and haven't really reached that point yet in the real world.