User Ka-King!, please don't offer poor advice in the CRMT section. The fact that you suggested move-boosting plates and fire/electric resist berries on Skarmory, along with your sig, leads me to believe that you should accumulate more competitive battling experience before helping people with their teams.
Jolteon should have Hidden Power Ice over Roar, and Subsitute over Shadow Ball. Roar has negative priority, and Jolteon is relatively fragile compared to the common leads that it would use Roar against. The item should be a Petaya Berry (raises special attack in a pinch), which allows you to Sub against Salamence, get the boost, and Hp Ice for a OHKO. In addition, when facing a slower pokemon, BPing some special attack to another special sweeper is a good plan.
Skarmory is fine as it is. I would run Shed Shell, if only to escape Magnezone, who rips apart your Skarmbliss combo and can destroy the rest of your team (Salamence too once it Magnet Rises). Blissey is best with Seismic Toss over Toxic, and Thunder Wave over Thunderbolt. Sing is a risky move, but it also is a good choice for Blissey. Seismic Toss is pretty much required if you have access to FR/LG because on most Pokemon, Ice Beam will be doing similar damage, often less than Seismic Toss.
Salamence should ditch Crunch, which only hits Cresselia and Dusknoir, the second of which has no business walling Salamence. Dragon Dance should be used instead of Crunch.
Ninjask is pretty much useless outside of a lead. Either use him as a lead with Focus Sash, or get rid of him and use this instead:
Tyranitar @ Choice Band
Ability: Sand Stream
Nature: Careful
Ev's: 252 Hp, 40 Atk, 216 Sp. Def
-Pursuit
-Crunch
-Stone Edge
-Earthquake
This will help you get rid of Magnezones, Togekiss, and Gengars who cause havoc to your team. This can switch in on Magnezone with impunity- it takes care of Togekiss and Gengar after something dies. However, this is still a good option as a special wall. It even survives a Togekiss Aura Sphere, along with a Gengar Focus Blast (but not in the same battle). Cresselia is also easily defeated by this Tyranitar, leaving your Salamence open for a lategame sweep.
Milotic should have a Modest nature to ensure the OHKO on Garchomp (provided it has no Yache Berry). The item should be leftovers.
Not a bad team, although I wonder why your friend would post it on Myspace- but I guess they have better raters than Yahoo Answers. Lol, even Marriland is better. But I guess if he's not into competitive battling, then this is a fine team.
