I've never really had much luck with shinies in comparison to other friends, but my findings have been fairly decent. In 4th gen (when I started playing Pokemon again) I got a shiny Golbat and I named it Edward. In SoulSilver I had the worst luck: I found a Hoothoot before you could get pokeballs...
To make matters worse, I turned my game off without saving and found it another 3 times. Eventually I changed how I walked and I didn't find it again. Much much later, I found a shiny sandshrew in the Safari Zone (gdi). Somehow, I managed to catch it and named it "Hoothoot" in honor of the one that got away.
I found no shinies in White version. Not 1.
6th gen has given me many. My first was a Masuda method I tried for the first time. I really wanted a shiny Mega-Gardevoir, so I bred till I got one and named it "Your Funeral." The first wild one I found was a Lilipup. I also chain fished a Quilfish (made me so happy!), a Poliwhirl, a Magikarp, and a Basculin.
Then this Saturday I got two in one day. The first I didn't even notice until I evolved it and that was a snivy.
The second I found while trying to get a female Togepi for a friend: a shiny Flotette.
I have pictures, but apparently I can't post them yet
Still upset that I had better chances at finding a shiny than that god forsaken togepi ugh. That took like 45 minutes.