AJ Flibble said:
Only have one Fire move for more diversity. You should only have 2 moves of the same type if they serve different purposes. And bear in mind some Pokemon shouldn't have any attacking moves at all aka Umbreon.
*cough* My Umbreon has 3 attack moves. ;P
Then again, she's a rare case who was (legitimately) hatched as Eevee with a high Special Attack IV, and a nature to boost it. Bit of EV training in Special Attack and she can KO a Pokemon of the same level in 2 attacks (or less if there's a type advantage) now.
On Topic:
I agree with what everyone else has said. Putting more than one move of the same type on a Pokemon is not smart at all. If Pokemon could learn more than four moves, then maybe you'd see more Venusaurs with Solar Beam and Giga Drain, but since four is, and always will be the limit, you have to make a Pokemon who will be prepared for anything.
Here's an example of why:
Imagine you're fighting a water type with only a few HP left. It's managed to knock out all but one of your Pokemon.. your fire type. You're forced to send it out, but with four fire-type moves the water type kicks your butt and you lose.
Now if your fire type had another attack like... say.. a Charizard with Dragon Claw, it possibly could have beaten the water type and you could have won the battle.
Now do you see why it's important to have a variety of types on one Pokemon?