Yes I got the national dex and beaten the elite 4 on leaf green. Do I need to do beat both versions then as I only want to trade with other people not myself.
Then has the other person/people you want to trade with beaten the E4 and gotten the National Dex? Also, keep in mind that R/S can't use the Wireless Adaptor. Only FR/LG/E can use the wireless trading function. Otherwise, use the GBA Trade Link Cable, the older TLC does not support GBA games.
Keep in Mind:
FR/LG trading to R/S/E - You must beat the Elite Four the first time, have the National Dex, and get the Ruby and Sapphire Plates to Celio.
R/S/E trading to FR/LG - You must beat the Elite Four and have the National Dex.
If both of these conditions are not met, you cannot trade to different games.
Also:
FR/LG trading to FR/LG - Beat the Elite Four the first time.
R/S/E trading to R/S/E - Beat the Elite Four.