Yeah - Aggron can be okay, but you have to watch out for ground and fighting - that 4x weak really hurts. And its movepool is a bit limited (except, oddly, for specials - it learns about any of the good special TMs, even though it can't use them very well).
Shiftry's a bit iffy too. I like Shiftry a lot, and have raised and trained two of them in Sapphire. It's tough to make it good though, since its movepool is very limited. I've got one set up as a sunnybeamer - Chlorophyll ability + Sunny Day / Solarbeam / Synthesis / HP Fire. When Sunny Day goes off, it increases its speed, Solarbeam becomes a one-turn move, Synthesis heals 2/3 instead of 1/2 and HP Fire does 150% damage. It's a fun moveset, but it's very limited and it's dangerous, since anything else with a fire attack also gets 150% damage, and Shiftry is weak to fire. And it was a chore getting one with Chlorophyll and HP Fire and decent stats - I went through an awful lot of eggs and released an awful lot of Seedots looking for one that would work. The other is Fake Out / Giga Drain / Faint Attack / Extrasensory, which is a more rounded moveset, but still only so-so.
If you want a grass/dark, Cacturne's almost certainly a better choice - it has lower hit points and speed and its ability isn't as potentially useful, but its attack stats and movepool are both much better.
For flying type, for Hoenn natives, you're pretty much limited to Swellow, Altaria, Ninjask, Tropius, Pelipper..... I think that's about it. Swellow is a standard bird - fast, hits hard, sort of fragile. Altaria is sort of fun to play, but it's a bit of a challenge. Swablu can't do a whole lot on its own, so it's a bit of a chore leveling it up until it evolves, and Altaria is a defensive specialist - mostly defense and annoyer moves. It attacks okay, but it's much better for setting up screens and such. I like Ninjask a lot, but it's a challenge to use well too. It hits really hard (especially after it uses Swords Dance a time or two) and it's naturally fast, and with a speed boost or two, it's faster than anything else in the game. But it's very fragile, so it's pretty much faint or be fainted. If it comes up against anything it's not resistant to (and even some things it is resistant to) and doesn't take it out in one hit, there's a pretty good chance that Ninjask isn't going to survive being hit. The other nice thing Ninjask has though is Baton Pass - if you see something come in that Ninjask might not be able to handle, you can just BP all those speed and attack increases on to someone else. I think Tropius is underrated myself - it's a great HM slave, and that's what most people use it for, but it's really not bad as a regular team member. It has mostly good stats and a good movepool, all things considered. Grass/flying is a bit limited and has too many weaknesses for my tastes, but Tropius actually can work on a team pretty well. And Pelipper is.... okay. Its stats are mostly only so-so, and it doesn't have much of a movepool and has a nasty 4x weakness to electric, but water/flying gives it a pretty wide range of things it's super effective against.
For fighting, I like Hariyama a lot - great stats and great moves. It's one of my favorite Hoenn pokemon. Medicham can also be really good, but it's sort of a novelty and doesn't show up until relatively late in the game. Breloom can also be good - great attack and good movepool, but it's a bit weak defensively and has some troublesome weaknesses.